From 07bd3f869934f10a472137e361754ea081662bf7 Mon Sep 17 00:00:00 2001
From: Michael Wegener <mw@satware.com>
Date: Wed, 24 Jun 2026 20:14:33 +0200
Subject: [PATCH] fix(ansible): harden AUR install task and rename ansible_user
 to local_user

- AUR task: replace loop with single paru call, use changed_when: false
  (stdout-only match never fired under non-TTY runs) and failed_when: false
  so transient AUR failures don't abort the play
- Rename ansible_user -> local_user to avoid shadowing the connection
  magic var; update the two references in roles/common/tasks/main.yml
---
 ansible/roles/common/tasks/main.yml    | 8 ++++----
 ansible/roles/dev-tools/tasks/main.yml | 8 ++++++++
 ansible/vars/main.yml                  | 1 +
 3 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/ansible/roles/common/tasks/main.yml b/ansible/roles/common/tasks/main.yml
index 780a227..984c3f4 100644
--- a/ansible/roles/common/tasks/main.yml
+++ b/ansible/roles/common/tasks/main.yml
@@ -3,8 +3,8 @@
   file:
     path: "{{ ansible_env.HOME }}/.config/kitty"
     state: directory
-    owner: "{{ ansible_user }}"
-    group: "{{ ansible_user }}"
+    owner: "{{ local_user }}"
+    group: "{{ local_user }}"
     mode: '0755'
   tags: [kitty, terminal]
 
@@ -12,8 +12,8 @@
   template:
     src: kitty.conf.j2
     dest: "{{ ansible_env.HOME }}/.config/kitty/kitty.conf"
-    owner: "{{ ansible_user }}"
-    group: "{{ ansible_user }}"
+    owner: "{{ local_user }}"
+    group: "{{ local_user }}"
     mode: '0644'
   vars:
     kitty_config_dir: "{{ ansible_env.HOME }}/.config/kitty"
diff --git a/ansible/roles/dev-tools/tasks/main.yml b/ansible/roles/dev-tools/tasks/main.yml
index 62cff63..1cded8e 100644
--- a/ansible/roles/dev-tools/tasks/main.yml
+++ b/ansible/roles/dev-tools/tasks/main.yml
@@ -86,6 +86,14 @@
   changed_when: false
   tags: [python, pipx]
 
+- name: Ensure JetBrains Toolbox and IntelliJ IDEA Ultimate are installed from AUR
+  become: true
+  become_user: "{{ system_user }}"
+  command: paru -S --noconfirm --needed jetbrains-toolbox intellij-idea-ultimate-edition
+  changed_when: false
+  failed_when: false
+  tags: [jetbrains, aur]
+
 - name: Ensure redundant and non-core software is removed
   community.general.pacman:
     name:
diff --git a/ansible/vars/main.yml b/ansible/vars/main.yml
index 0d7906d..e4af599 100644
--- a/ansible/vars/main.yml
+++ b/ansible/vars/main.yml
@@ -1,5 +1,6 @@
 # mw-pfeddersheim-workstation variables
 system_user: mw
+local_user: "{{ system_user }}"
 root_filesystem_uuid: 2aeade2e-b169-4964-8cbd-bb7356320b51
 root_filesystem_mount_opts: noatime
 swap_file_path: /swapfile